fix: ensure GraphConfig.root_dir is an absolute path #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2025
ahal
reviewed
Apr 9, 2025
src/taskgraph/config.py
Outdated
| @@ -157,6 +157,9 @@ def validate_graph_config(config): | |||
|
|
|||
|
|
|||
| def load_graph_config(root_dir): | |||
| # ensure we have an absolute path; this is required for assumptions | |||
| # made later, such as the `vcs_root` being a directory above `root_dir` | |||
| root_dir = os.path.abspath(root_dir) | |||
There was a problem hiding this comment.
In theory, I think this should go in the __post_init__ method of GraphConfig. In practice, I don't think it really matters. Given GraphConfig is frozen, it would mean we'd need to use object.__setattr__ to set it, so this is probably fine.
There was a problem hiding this comment.
ah; but if there's ever anything else that creates a GraphConfig that could be a problem, I think? This seems like an easy change to make.
There was a problem hiding this comment.
ahal
approved these changes
Apr 9, 2025
|
failures are codecov (meh) and pre-commit (issue on their side). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.